Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support of bool #654

Merged
merged 22 commits into from Jan 24, 2023
Merged

Fix support of bool #654

merged 22 commits into from Jan 24, 2023

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 25, 2022

Fix #647

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2022 •
edited

Codecov Report

Merging #654 (2689f58) into master (4ad3555) will increase coverage by 0.75%.
The diff coverage is 97.93%.

@@            Coverage Diff             @@
##           master     #654      +/-   ##
==========================================
+ Coverage   80.17%   80.92%   +0.75%     
==========================================
  Files          66       67       +1     
  Lines        3975     4079     +104     
==========================================
+ Hits         3187     3301     +114     
+ Misses        788      778      -10
Impacted Files Coverage Δ
include/highfive/H5DataType.hpp 89.23% <ø> (ø)
include/highfive/bits/H5Node_traits.hpp 100.00% <ø> (ø)
include/highfive/bits/H5Converter_misc.hpp 84.94% <77.77%> (+3.04%) ⬆️
include/highfive/bits/H5DataType_misc.hpp 80.51% <100.00%> (+2.20%) ⬆️
include/highfive/bits/H5Node_traits_misc.hpp 87.28% <100.00%> (ø)
tests/unit/test_all_types.cpp 100.00% <100.00%> (ø)
tests/unit/tests_high_five_base.cpp 99.58% <0.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alkino alkino mentioned this pull request Jan 20, 2023
Closed
@alkino alkino linked an issue Jan 20, 2023 that may be closed by this pull request
Writing containers of bools failes to compile #490
Closed
@alkino alkino mentioned this pull request Jan 20, 2023
Closed
@alkino alkino linked an issue Jan 20, 2023 that may be closed by this pull request
Is this working for std::vector<bool>? Thanks #25
Closed
@pramodk pramodk requested a review from 1uc January 20, 2023 16:34
matz-e
matz-e reviewed Jan 20, 2023
View reviewed changes
Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick wording check

include/highfive/bits/H5Converter_misc.hpp Outdated Show resolved Hide resolved
1uc
1uc approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work!

@alkino alkino merged commit 8a93fdf into master Jan 24, 2023
@alkino alkino deleted the cornu/fix_support_of_bool branch January 24, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz-e matz-e matz-e left review comments

@1uc 1uc 1uc approved these changes

@ohm314 ohm314 Awaiting requested review from ohm314

@ferdonline ferdonline Awaiting requested review from ferdonline

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@alkino @codecov-commenter @matz-e @1uc