New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add access to values of properties #684
Conversation
764fad5
to
c599963
Compare
I wonder if we should return tuple instead of having one getter for each value. Should we do a static function instead? static std::tuple<hsize_t, hsize_t> fromDataTransferProps(dxpl); |
c599963
to
eae2197
Compare
Codecov Report
@@ Coverage Diff @@
## master #684 +/- ##
==========================================
+ Coverage 80.28% 80.35% +0.07%
==========================================
Files 68 68
Lines 4113 4123 +10
==========================================
+ Hits 3302 3313 +11
+ Misses 811 810 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eae2197
to
76a812e
Compare
b59226d
to
c2b2583
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks pretty clean. The only place I'd return a pair is for the version bounds.
And we don't have too many other free functions, do we? So your current API seems fine to me.
API can be discussed