Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add access to values of properties #684

Merged
merged 18 commits into from Feb 10, 2023
Merged

Add access to values of properties #684

merged 18 commits into from Feb 10, 2023

Conversation

alkino
Copy link
Member

@alkino alkino commented Feb 5, 2023

API can be discussed

@alkino
Copy link
Member Author

alkino commented Feb 5, 2023

I wonder if we should return tuple instead of having one getter for each value.

Should we do a static function instead?

static std::tuple<hsize_t, hsize_t> fromDataTransferProps(dxpl);

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Merging #684 (52da3ee) into master (4e5e971) will increase coverage by 0.07%.
The diff coverage is 85.93%.

@@            Coverage Diff             @@
##           master     #684      +/-   ##
==========================================
+ Coverage   80.28%   80.35%   +0.07%     
==========================================
  Files          68       68              
  Lines        4113     4123      +10     
==========================================
+ Hits         3302     3313      +11     
+ Misses        811      810       -1     
Impacted Files Coverage Δ
include/highfive/H5PropertyList.hpp 93.33% <0.00%> (-4.17%) ⬇️
include/highfive/bits/H5PropertyList_misc.hpp 72.46% <85.45%> (+8.60%) ⬆️
include/highfive/H5Group.hpp 100.00% <100.00%> (+14.28%) ⬆️
include/highfive/bits/H5File_misc.hpp 95.23% <100.00%> (+7.89%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks pretty clean. The only place I'd return a pair is for the version bounds.

And we don't have too many other free functions, do we? So your current API seems fine to me.

include/highfive/H5PropertyList.hpp Outdated Show resolved Hide resolved
@alkino alkino merged commit cd5cc8f into master Feb 10, 2023
@alkino alkino deleted the cornu/add_read_properties branch February 10, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants