Allow users to set Boost_NO_BOOST_CMAKE.
#687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forcing `Boost_NO_BOOST_CMAKE=On` was reported to cause build failure in: #685 This commit keeps the current default, but respects the users choice.
|
Looking over the various CMake code, I feel it's in need of a general overhaul. Therefore, I prefer the solution that tries to avoid potentially breaking build systems twice in a row. |
Codecov Report
@@ Coverage Diff @@
## master #687 +/- ##
=======================================
Coverage 81.16% 81.16%
=======================================
Files 67 67
Lines 4151 4151
=======================================
Hits 3369 3369
Misses 782 782 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
matz-e
approved these changes
Feb 10, 2023
alkino
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing
Boost_NO_BOOST_CMAKE=Onwas reported to cause build failure in:#685
This commit keeps the current default, but respects the users choice.