Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation failures for custom installation locations #726

Merged
merged 1 commit into from Apr 3, 2023

Conversation

ischoegl
Copy link
Contributor

@ischoegl ischoegl commented Apr 3, 2023

Description

This PR fixes an import statement that causes compilations to fail when trying to use HighFive as a header-only library with custom install locations. Symptoms are: (i) fatal error: 'highfive/H5Utiity.hpp' not found if the conda environment does not contain a system highfive or (ii) a long error stack starting with error: redefinition of 'SilencedHDF5' [...] if trying to compile with a custom location while having a highfive package installed. Using the relative import (which is used everywhere else) fixes the issue.

  • fixed relative import

How to test this?

cmake ..
make -j8
make test

Test System

  • OS: macOS (inside conda environment with/without highfive package installed)
  • Compiler: AppleClang 14.0.3
  • Dependency versions: hdf5 1.12

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #726 (a27c129) into master (e3c2f8c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #726   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files          67       67           
  Lines        4503     4503           
=======================================
  Hits         3710     3710           
  Misses        793      793           
Impacted Files Coverage Δ
include/highfive/bits/H5Object_misc.hpp 90.24% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alkino alkino merged commit 3d738b0 into BlueBrain:master Apr 3, 2023
24 checks passed
@ischoegl ischoegl deleted the fix-import branch April 3, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants