Avoid MSVC compiler bug. #728
Conversation
|
We can compare two versions: but different compiler versions: Checking: https://blog.knatten.org/2022/08/26/microsoft-c-versions-explained/ Comparing to path information found in Cantera CI we see: https://github.com/Cantera/cantera/actions/runs/4588940048/jobs/8103492434#step:5:12 Which is probably consistent since the knatten's blog suggests that Visual Studio 2022 has MSVC versions |
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
=======================================
Coverage 82.43% 82.43%
=======================================
Files 67 67
Lines 4514 4514
=======================================
Hits 3721 3721
Misses 793 793
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
1uc
force-pushed
the
1uc/add-older-msvc
branch
2 times, most recently
from
8ec15aa
to
4aec900
Compare
|
Should be merged after #729. |
This commit reintroduces the friend decrations removed in `20be06f` for MSVC. Certain versions of MSVC (toolset 141, possibly others) fail to compile otherwise. Furthermore, this commit adds CI to compile HighFive on a wider range of MSVC compilers.
1uc
changed the title
The purpose of this MR is to get older versions of MSVC to compile HighFive. The hope is it'll reproduce the issue in #724. This fixes required are also included in this PR.