Allow user-specified mem_space for hyperslabs.
#740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows users to specify the memory dataspace. Previously, we forced the memspace to be 1D, because in general a hyperslab selection isn't a multi-dimensional block anymore. We now allow users to specify the memory dataspace, which must be simple; but can be multi-dimensional.
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
=======================================
Coverage 82.47% 82.47%
=======================================
Files 67 67
Lines 4543 4543
=======================================
Hits 3747 3747
Misses 796 796
|
pramodk
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows users to specify the memory dataspace. Previously, we forced the memspace to be 1D, because in general a hyperslab selection isn't a multi-dimensional block anymore.
We now allow users to specify the memory dataspace, which must be simple; but can be multi-dimensional.