Move inspector to its own file.
#759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit prepares for the `data_converter`, `Reader` and `Writer` to depend on `DataType`. This would cause the includes to become cyclic since the `DataType` requires the inspector. Note that this commit only moves code from one file to the next without any other changes.
Codecov Report
@@ Coverage Diff @@
## master #759 +/- ##
==========================================
+ Coverage 83.62% 83.67% +0.04%
==========================================
Files 66 67 +1
Lines 4496 4496
==========================================
+ Hits 3760 3762 +2
+ Misses 736 734 -2
|
matz-e
approved these changes
May 29, 2023
alkino
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prepares for the
data_converter,ReaderandWriterto depend onDataType. This would cause the includes to become cyclic since theDataTyperequires the inspector.Note that this commit only moves code from one file to the next without any other changes.