Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also run project integration CI for pHDF5. #760

Merged
merged 2 commits into from May 26, 2023
Merged

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented May 26, 2023

This aim is to prevent build failures, e.g. missing inline, when using a parallel version of HDF5. In HighFive there's some code that's only compiled with the parallel version of HDF5. See #638.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #760 (2a93083) into master (4433372) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   83.62%   83.62%           
=======================================
  Files          66       66           
  Lines        4496     4496           
=======================================
  Hits         3760     3760           
  Misses        736      736           

@1uc 1uc force-pushed the 1uc/project-integration-phdf5 branch from f77c806 to 60c3e3d Compare May 26, 2023 08:41
@1uc
Copy link
Collaborator Author

1uc commented May 26, 2023

This:
https://github.com/BlueBrain/HighFive/actions/runs/5089009161/jobs/9146119240?pr=760

confirms that the parallel version is now also compiled and picks up MPI.

@1uc 1uc marked this pull request as ready for review May 26, 2023 09:14
@1uc
Copy link
Collaborator Author

1uc commented May 26, 2023

This:
https://github.com/BlueBrain/HighFive/actions/runs/5089009161/jobs/9146119240?pr=760

confirms that the parallel version is now also compiled and picks up MPI.

@1uc 1uc force-pushed the 1uc/project-integration-phdf5 branch from d1f1fa0 to baa59cc Compare May 26, 2023 12:00
@1uc 1uc merged commit 9aa6046 into master May 26, 2023
30 checks passed
@1uc 1uc deleted the 1uc/project-integration-phdf5 branch May 26, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants