Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ci.yml DRYer. #761

Merged
merged 1 commit into from May 26, 2023
Merged

Make ci.yml DRYer. #761

merged 1 commit into from May 26, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented May 26, 2023

We use include: to run all combinations of Windows, even if they cant' exactly be described by a matrix.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #761 (98600d2) into master (4573fd3) will not change coverage.
The diff coverage is n/a.

❗ Current head 98600d2 differs from pull request most recent head b222528. Consider uploading reports for the commit b222528 to get more accurate results

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   83.62%   83.62%           
=======================================
  Files          66       66           
  Lines        4496     4496           
=======================================
  Hits         3760     3760           
  Misses        736      736           

@1uc 1uc marked this pull request as ready for review May 26, 2023 09:18
We use `include:` to run all combinations of Windows, even if they
cant' exactly be described by a matrix.
Copy link
Member

@alkino alkino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that CI was running what it told us

@alkino alkino merged commit 4433372 into master May 26, 2023
29 checks passed
@alkino alkino deleted the 1uc/dryer-ci branch May 26, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants