Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New property: enable setting attribute phase change thresholds. #785

Merged
merged 2 commits into from Jul 10, 2023

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Jun 30, 2023

This commit adds the ability to set the thresholds at which attributes are stored in dense and compact storage. This is needed for example to write very large attributes, see #783.

@1uc 1uc force-pushed the 1uc/issue-783 branch 2 times, most recently from de0578c to afc4a68 Compare June 30, 2023 07:53
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #785 (9e74a84) into master (edd5fe4) will decrease coverage by 0.10%.
The diff coverage is 73.17%.

@@            Coverage Diff             @@
##           master     #785      +/-   ##
==========================================
- Coverage   84.27%   84.18%   -0.10%     
==========================================
  Files          67       68       +1     
  Lines        4713     4754      +41     
==========================================
+ Hits         3972     4002      +30     
- Misses        741      752      +11     
Impacted Files Coverage Δ
include/highfive/H5PropertyList.hpp 93.75% <ø> (ø)
src/examples/create_large_attribute.cpp 0.00% <0.00%> (ø)
include/highfive/bits/H5PropertyList_misc.hpp 76.43% <90.00%> (+0.92%) ⬆️
tests/unit/tests_high_five_base.cpp 99.69% <100.00%> (+<0.01%) ⬆️

@1uc 1uc marked this pull request as ready for review June 30, 2023 08:28
@1uc 1uc force-pushed the 1uc/issue-783 branch 2 times, most recently from cdb9556 to 9bd9c7e Compare June 30, 2023 15:03
matz-e
matz-e previously approved these changes Jun 30, 2023
@alkino alkino changed the title Enable setting attribute phase change thresholds. New property: enable setting attribute phase change thresholds. Jul 10, 2023
@1uc 1uc merged commit e38bb46 into master Jul 10, 2023
30 checks passed
@1uc 1uc deleted the 1uc/issue-783 branch July 10, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants