Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free return of H5Tget_member_name #798

Merged
merged 2 commits into from Jul 11, 2023
Merged

Free return of H5Tget_member_name #798

merged 2 commits into from Jul 11, 2023

Conversation

alkino
Copy link
Member

@alkino alkino commented Jul 11, 2023

Tests have been run with and without fix.

@alkino alkino requested a review from 1uc July 11, 2023 09:04
include/highfive/H5DataType.hpp Outdated Show resolved Hide resolved
include/highfive/H5DataType.hpp Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #798 (175a707) into master (59e6f41) will increase coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   84.18%   84.21%   +0.03%     
==========================================
  Files          68       68              
  Lines        4754     4776      +22     
==========================================
+ Hits         4002     4022      +20     
- Misses        752      754       +2     
Impacted Files Coverage Δ
include/highfive/H5DataType.hpp 89.88% <75.00%> (+0.03%) ⬆️
tests/unit/tests_high_five_base.cpp 99.69% <100.00%> (+<0.01%) ⬆️

@alkino alkino merged commit d2b1173 into master Jul 11, 2023
30 checks passed
@alkino alkino deleted the cornu/clean_compound_name branch July 11, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants