Add and use <highfive/highfive.hpp>.
#818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would require that we include |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #818 +/- ##
==========================================
- Coverage 84.73% 84.72% -0.01%
==========================================
Files 69 69
Lines 5043 5042 -1
==========================================
- Hits 4273 4272 -1
Misses 770 770
☔ View full report in Codecov by Sentry. |
matz-e
approved these changes
Oct 31, 2023
1uc
force-pushed
the
1uc/highfive-top-level-include
branch
from
d4a2fa6
to
f3bcc4c
Compare
alkino
approved these changes
Oct 31, 2023
The header `<highfive/highfive.hpp>` is the top-level header for everything HighFive. It's recommended to use it instead of the other headers, unless compilation time is a concern. However, currently `<highfive/H5File.hpp>` includes almost all of HighFive. Hence, the savings are likely very modest, if any.
1uc
force-pushed
the
1uc/highfive-top-level-include
branch
from
f3bcc4c
to
5485bab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header
<highfive/highfive.hpp>is the top-level header for everything HighFive. It's recommended to use it instead of the other headers, unless compilation time is a concern. However, currently<highfive/H5File.hpp>includes almost all of HighFive. Hence, the savings are likely very modest, if any.