Implement event-driven rendering #101
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
|
@favreau: There is a small chance this breaks VWS. requestFrame does postRedraw(), and I think this should be sufficient to reach the publishFrame(), but I could/did not test it. |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Don't merge. Found a race. |
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -34,14 +34,6 @@ class CacheObjectObserver | |||
| friend class CacheObject; | |||
|
|
|||
| protected: | |||
|
|
|||
| /** | |||
| * Notifies the \see CacheObserver before loading. | |||
There was a problem hiding this comment.
Was unused, and it simplified some code I removed later.
There was a problem hiding this comment.
Can we take it back, or remove preunload to ? It is not symmetric like this.
|
Good to review (and merge if Jenkins agrees) |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
Something is failing on the cache test. |
|
Yep, no override/final on a virtual :P |
* eqPly-style Client main loop * Add Config::postRedraw/needRedraw * Move heartbeat publish to event handling (from frame()) * post redraw from events, ZeroEQ handlers and TextureUploader Cleanups: * rm unused CacheObjectObserver::onPreLoad_ * Variable naming * do Window pipeline setup in one place
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
1 similar comment
|
retest this please |
|
So the retest works for you, but not for me. Great. (see https://bbpteam.epfl.ch/project/issues/browse/HELP-3851) |
|
Sometimes you have two do twice, three times etc.
|
|
Refer to this link for build results (access rights to CI server needed): |
Implement event-driven rendering
No description provided.