-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
b27ec06
to
1c7411c
Compare
{ | ||
LBASSERT( cacheObjectID != INVALID_CACHE_ID ); | ||
ReadLock readLock( mutex_ ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ScopedMutex semantics and scoped code, please.
Pipeline* pipeline = dynamic_cast<Pipeline*>( executable.get( )); | ||
if( pipeline ) | ||
{ | ||
int zzzz; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zzzz??? :-)
+1 for my part, someone else can give the +2. It is a large change - try to merge after careful testing and bug fixing :-) |
|
||
namespace livre | ||
{ | ||
|
||
Processor::Processor() | ||
/** | ||
* The Executable class is the base clas for objects that can be executed by workers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo clas
Style: In doxygen I already see that this is the Executable class. I prefer:
'Base class for objects that can be executed by workers' , i.e., DRY.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I call a filter in the ISC document?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. It is independent from where it is being executed.
Is there an overview on all the pipeline classes? Either some doxygen or UML diagram? I got lost in all the input/output filter/executor/port permutations. |
e94c520
to
643f7c0
Compare
I am thinking about a presentation for it. I did not have time :) |
Cleanups & Refactorings before the Pipeline merge #188
#188 implemented all functionality of this commit |
So, my pipelines are here:
Why did I do this ?
I am creating this pull req in order to discuss / change or even completely delete ( I am fine with it). I think at the end I really had a nice idea of using graph based algorithms and if we dont use it, I will make a library called "TaskTube" :) for my own things.
Do jump in if you want but I would like to go with a couple of people different regions of the code.
Known issue: On exit I am getting
21218.Main ../Collage/co/localNode.cpp:387 8284 0 connections open after close
21218.Main ../apps/livre/livre.cpp:90 8284 Assert: client->getRefCount() == 1 [Client still referenced by 7] in:
but I will have a look at it.