This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
Samples are starting at the boundaries of the global AABB #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
| @@ -164,6 +164,14 @@ struct RayCastRenderer::Impl | |||
| tParamNameGL = glGetUniformLocation( program, "invModelViewMatrix" ); | |||
| glUniformMatrix4fv( tParamNameGL, 1, false, frustum.getInvModelViewMatrix( ).array ); | |||
|
|
|||
| tParamNameGL = glGetUniformLocation( program, "globalAabbMin" ); | |||
There was a problem hiding this comment.
Add a note while you are dividing by two.
|
add a changelog to notify which fix number you have fixed. I did not do that before myself on the previous 3 fixes, but you can do it :) |
|
I am a bit lost... There is no issue opened for this one and also this issue was not existing in the previous release because it was introduced by this recent nyquist limit computation Should I write in the changeog something like: "Imporvment: Samples start from the boundaries of the global AABB" ??? |
|
Ready to merge ?? :) |
| @@ -164,6 +164,16 @@ struct RayCastRenderer::Impl | |||
| tParamNameGL = glGetUniformLocation( program, "invModelViewMatrix" ); | |||
| glUniformMatrix4fv( tParamNameGL, 1, false, frustum.getInvModelViewMatrix( ).array ); | |||
|
|
|||
| // Because the volume is centered to the origin we can compute the volume AABB by using | |||
| // the volume total size. | |||
| Vector3f halfWorldSize = _volInfo.worldSize / 2.0; | |||
|
Updated |
|
+1 |
bilgili
pushed a commit
that referenced
this pull request
Dec 2, 2015
Samples are starting at the boundaries of the global AABB
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.