Pipeline and rendering with pipeline implementation #256
Conversation
| @@ -0,0 +1,63 @@ | |||
| /* Copyright (c) 2011-2014, EPFL/Blue Brain Project | |||
bilgili
force-pushed
the
pipeline
branch
6 times, most recently
from
6db9e3f
to
e365b1e
Compare
| * Executes the executable. Returns the futures that can be queried for data. | ||
| * @param pipeline to be executed. | ||
| */ | ||
| Futures execute( const ExecutablePtr& executable ) |
There was a problem hiding this comment.
We've discussed this before. Yes, const Ptr& is the preferred way to pass smart pointers as function arguments because it saves the automic counter increment. Whether the pointer is finally stored by the callee is an orthogonal issue.
There was a problem hiding this comment.
I think, overall I should decrease the usage of Ptrs around. Lots of them makes things a bit fishy. Implementation are generally private so, it is possible to share them.
| { | ||
| for( const auto& future: futures ) | ||
| addFuture( future.getName(), future ); | ||
|
|
| { | ||
| const Boxf& worldBox = lodNode.getWorldBox(); | ||
| const bool isInFrustum = _frustum.boxInFrustum( worldBox ); | ||
| if( !isInFrustum ) |
There was a problem hiding this comment.
I don't know if it's better... But you can collapse these two line:
if( !_frustum.boxInFrustum( worldBox ))
There was a problem hiding this comment.
Actually I am not sure if it make things more clear...
There was a problem hiding this comment.
It does not add value but does not cloud information as well, so I rather keep it this way
There was a problem hiding this comment.
I'm with chevtche in this one.
There was a problem hiding this comment.
:) I am with my self but I would do !
|
+1 |
No description provided.