Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

Bug fixes #270

Merged
merged 4 commits into from
Apr 5, 2016
Merged

Bug fixes #270

merged 4 commits into from
Apr 5, 2016

Conversation

bilgili
Copy link
Contributor

@bilgili bilgili commented Mar 31, 2016

No description provided.

@eile
Copy link
Contributor

eile commented Mar 31, 2016

Hard for me to understand: Is the LOD selection now independent of the window size? If no, where is it taken into account?

@bilgili
Copy link
Contributor Author

bilgili commented Mar 31, 2016

Yes it is now. I am just finding the projection of (n) pixel in a distance and, I am finding which LOD of the data has the closest number of voxels of the whole data for that projected pixel. The TUVOK one was much more complicated. If volume is 4k^3, 256^3 blocks, 5 depth, and sse is 2 ( 1 voxel is two pixels ) and volume is just front of the near plane, you can directly use the 2048^3 volume where each voxel is exactly two pixels of the data.

@bilgili
Copy link
Contributor Author

bilgili commented Apr 1, 2016

so ?

@bilgili bilgili force-pushed the bug_fixes branch 3 times, most recently from 3660024 to f1ba50a Compare April 5, 2016 14:35

// Explicit registration required because the folder of the data source plugin is not
// in the LD_LIBRARY_PATH of the test executable.
lunchbox::PluginRegisterer< livre::MemoryDataSource > registerer;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember the RH and Ubuntu was behaving differently in link time about registering the data sources ( I had a problem with uvf before thats why I have added ).

@eile
Copy link
Contributor

eile commented Apr 5, 2016

+1

Can you change the default camera pos to 1.5? Then the front of the volume will be on the near plane for a square window.

@bilgili
Copy link
Contributor Author

bilgili commented Apr 5, 2016

0.6 ( 0.5 the half width of volume + 0.1 near plane ) will make the volume right in front of the plane. 1.5 The volume will be farther ( double checked ). 1.5 includes all the volume.

@bilgili bilgili merged commit 687fc2d into BlueBrain:master Apr 5, 2016
@bilgili bilgili deleted the bug_fixes branch October 4, 2016 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants