Flattenning the DashTree #28
Conversation
bilgili
commented
May 22, 2015
bilgili
commented
- Seperating the Dash from DataSource
- Simplified dash interfaces
- Moving touched classes ( which will be used in future as well ) to private implementations
|
Refer to this link for build results (access rights to CI server needed): |
| @@ -43,6 +48,7 @@ class Node : public eq::Node, public DashContextTrait | |||
| * @param parent Parent config that owns the Node. | |||
| */ | |||
| Node( eq::Config* parent ); | |||
| ~Node(); | |||
There was a problem hiding this comment.
virtual - also for other classes (Pipe etc)
There was a problem hiding this comment.
Parent classes has virtual keyword already. It should be sufficient, no ?
|
I tried to review this, but it's virtually impossible. Looks good on a first glance, but with all the refactorings it is impossible to see the "flattening" code. |
|
|
Refer to this link for build results (access rights to CI server needed): |
- Seperated the Dash from DataSource - Simplified dash interfaces - Moved touched classes ( which will be used in future as well ) to private implementations - Dash nodes are being generated on the fly as they are accessed.
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
+2 ( Only left part is the servus ) |
|
Self +2? |
|
+2 for my CR I guess. +1 for me on this review then. Anybody else wants to review? If not, my +1 becomes +2. |
|
Build depends on Lunchbox/Servus which is WIP by @hernando |
|
Once #30 is merged, rebase onto this, wait for build to be green and merge |
|
Refer to this link for build results (access rights to CI server needed): |
Flattenning the DashTree - Dash nodes are generated when they are requested only. With deep octrees this improves the startup time.
