This repository has been archived by the owner on Jul 8, 2022. It is now read-only.
Descriptions for plugins #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eile
force-pushed
the
master
branch
4 times, most recently
from
9a0cd3a
to
d0d3610
Compare
|
crossref Eyescale/Lunchbox#294 |
tribal-tec
reviewed
Jan 10, 2017
| @@ -59,6 +60,7 @@ int main( const int argc, char** argv ) | |||
| { | |||
| if( std::string( "--help" ) == argv[i] ) | |||
| { | |||
| livre::DataSource::loadPlugins(); // needed to complete --volume | |||
There was a problem hiding this comment.
hide in Client::getHelp(). Or leave it, as it will conflict with my upcoming changes
tribal-tec
reviewed
Jan 10, 2017
| @@ -20,64 +20,33 @@ | |||
|
|
|||
| #include <livre/core/defines.h> | |||
| #include <livre/core/configuration/Configuration.h> | |||
| #include <lunchbox/term.h> | |||
There was a problem hiding this comment.
missing .gitsubprojects bump then
There was a problem hiding this comment.
Missing +1 in Eyescale/Lunchbox#294
tribal-tec
reviewed
Jan 10, 2017
| @@ -47,6 +47,8 @@ class DataSource | |||
| /** Load all plugin DSOs. */ | |||
| LIVRECORE_API static void loadPlugins(); | |||
|
|
|||
| static std::string getDescriptions(); | |||
tribal-tec
reviewed
Jan 10, 2017
| renderSettings.setID( servus::make_uint128( "eq::RenderSettings" )); | ||
| cameraSettings.setID( servus::make_uint128( "eq::CameraSettings" )); | ||
| volumeSettings.setID( servus::make_uint128( "eq::VolumeSettings" )); | ||
| frameSettings.setID( servus::make_uint128( "livre::FrameSettings" )); |
eile
pushed a commit
to eile/Livre
that referenced
this pull request
Jan 10, 2017
tribal-tec
suggested changes
Jan 11, 2017
eile
pushed a commit
to eile/Livre
that referenced
this pull request
Jan 11, 2017
eile
pushed a commit
to eile/Livre
that referenced
this pull request
Jan 11, 2017
|
Changelog done |
tribal-tec
approved these changes
Jan 11, 2017
added 2 commits
January 11, 2017 15:20
|
Retest this please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.