Skip to content
This repository has been archived by the owner on Jul 8, 2022. It is now read-only.

livre_batch feature, help & version print cleanup, use 'Simple' layout by default, improve window title #70

Merged
merged 4 commits into from
Jul 6, 2015

Conversation

tribal-tec
Copy link
Contributor

No description provided.

eq::exit();
// cppcheck-suppress unreachableCode
livre::exitErrors();
return EXIT_SUCCESS;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not EXIT_FAILURE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no. If help or version, then (obviously) not, otherwise maybe. What now?

@eile
Copy link
Contributor

eile commented Jul 3, 2015

+1 otherwise

@bbpbuildbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://bbpcode.epfl.ch/ci//job/oss.Livre.github/137/
Test PASSed.

@tribal-tec tribal-tec changed the title livre_batch feature, help & version print cleanup livre_batch feature, help & version print cleanup, use 'Simple' layout by default Jul 3, 2015
@tribal-tec
Copy link
Contributor Author

updated

@bbpbuildbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://bbpcode.epfl.ch/ci//job/oss.Livre.github/139/
Test FAILed.

@tribal-tec tribal-tec changed the title livre_batch feature, help & version print cleanup, use 'Simple' layout by default livre_batch feature, help & version print cleanup, use 'Simple' layout by default, improve window title Jul 3, 2015
@bbpbuildbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://bbpcode.epfl.ch/ci//job/oss.Livre.github/140/
Test FAILed.

@eile
Copy link
Contributor

eile commented Jul 4, 2015

Retest this please

@@ -55,6 +55,20 @@ class NodeFactory : public eq::NodeFactory

int main( const int argc, char** argv )
{
for( int i =1; i < argc; ++i )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stuck space bar?

@tribal-tec
Copy link
Contributor Author

Retest this please

@bbpbuildbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://bbpcode.epfl.ch/ci//job/oss.Livre.github/141/
Test PASSed.

@eile
Copy link
Contributor

eile commented Jul 6, 2015

+1

tribal-tec added a commit that referenced this pull request Jul 6, 2015
livre_batch feature, help & version print cleanup, use 'Simple' layout by default, improve window title
@tribal-tec tribal-tec merged commit 335d6ec into BlueBrain:master Jul 6, 2015
@bbpbuildbot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://bbpcode.epfl.ch/ci//job/oss.Livre.github/142/
Test PASSed.

std::stringstream windowTitle;
windowTitle << "Livre " << Version::getString();
setName( windowTitle.str( ));

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eyescale/Equalizer#463 might obsolete this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants