Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external pybind11 #337

Closed
musicinmybrain opened this issue Sep 1, 2021 · 3 comments · Fixed by #351
Closed

Support external pybind11 #337

musicinmybrain opened this issue Sep 1, 2021 · 3 comments · Fixed by #351

Comments

@musicinmybrain
Copy link
Contributor

In general, pybind11 supports use with add_subdirectory(extern/pybind11) or from an install with find_package(pybind11 CONFIG) (https://pybind11.readthedocs.io/en/stable/cmake/index.html, https://pybind11.readthedocs.io/en/stable/compiling.html#building-with-cmake).

I’ve tried to do this downstream in Fedora Linux, but couldn’t manage to untangle CMake enough to get it working properly in this particular case. An EXTERNAL_PYBIND11 option, similar to the existing EXTERNAL_HIGHFIVE, would be a big help!

This isn’t a critical issue, as Fedora Linux guidelines do allow us to continue to bundle pybind11 as long as upstream does not support building with an external copy.

@mgeplf
Copy link
Contributor

mgeplf commented Sep 2, 2021

That seems reasonable; on the one hand it's a header only library, but on the other I appreciate people who are doing the heavy lifting of packaging things.

This isn’t a critical issue,

Is there a timeline for that, so I can prioritize it appropriately? I'm pretty overwhelmed at the moment.

Thanks!

@musicinmybrain
Copy link
Contributor Author

musicinmybrain commented Sep 2, 2021

I would put it at a low or background priority, with no particular timeline.

There are benefits to unbundling in a distribution, but in cases like this one where there’s no clear way to use the external library, it’s perfectly acceptable for the Fedora package to keep using the bundled library.

Thanks for considering the idea!

@musicinmybrain
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants