Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove py37, add py311, and fix Rectangle kwarg error #1082

Merged
merged 6 commits into from
Sep 15, 2023
Merged

Remove py37, add py311, and fix Rectangle kwarg error #1082

merged 6 commits into from
Sep 15, 2023

Conversation

eleftherioszisis
Copy link
Collaborator

No description provided.

@eleftherioszisis eleftherioszisis changed the title Remove py3.7, add py311, and fix Rectangle kwarg error Remove py37, add py311, and fix Rectangle kwarg error Sep 15, 2023
adrien-berchet
adrien-berchet reviewed Sep 15, 2023
View reviewed changes
Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was about to start working on that 😄

.github/workflows/run-tox.yml Outdated Show resolved Hide resolved
@adrien-berchet
Copy link
Member

adrien-berchet commented Sep 15, 2023 •
edited
Loading

I suggest you bump matplotlib>=3.6 in setup.py

EDIT: Ah no, nvm 😄

@eleftherioszisis @adrien-berchet
Update .github/workflows/run-tox.yml
822f4b5 
Co-authored-by: Adrien Berchet <adrien.berchet@epfl.ch>
@adrien-berchet adrien-berchet linked an issue Sep 15, 2023 that may be closed by this pull request
Broken call to Rectangle constructor #1079
Closed
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023 •
edited
Loading

Codecov Report

Merging #1082 (9783ee7) into master (20bddc5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #1082   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines         2452      2452           
=========================================
  Hits          2452      2452

adrien-berchet
adrien-berchet requested changes Sep 15, 2023
View reviewed changes
Copy link
Member

@adrien-berchet adrien-berchet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, we should also change the Python version in setup.py

@eleftherioszisis
Copy link
Collaborator Author

Oh wait, we should also change the Python version in setup.py

Done.

@adrien-berchet
Copy link
Member

I also found old Py versions in doc/source/developer.rst, should we update it too?

@adrien-berchet
Copy link
Member

LGTM, thanks!

@eleftherioszisis eleftherioszisis merged commit 8d856e5 into master Sep 15, 2023
4 checks passed
@eleftherioszisis eleftherioszisis deleted the remove-py3.7 branch September 15, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-berchet adrien-berchet adrien-berchet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken call to Rectangle constructor
3 participants
@eleftherioszisis @adrien-berchet @codecov-commenter