Remove a few useless shebang lines #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A shebang line is only meaningful in a file with the executable bit set in its permissions. These examples are already correctly non-executable, as they have no “main routine” or interesting side effects and are purely importable modules. The file examples/density_plot.py fits the same description, but already lacks a shebang line.
A shebang line is only meaningful in a file with the executable bit set in its permissions. This module is designed to be imported, not directly executed: it is already correctly non-executable, and it has no “main routine” or interesting side effects.
|
Looks good, thanks for the contribution. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 36 36
Lines 2452 2452
=========================================
Hits 2452 2452 |
mgeplf
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove shebang lines from a few files that do not need them.
A shebang line is only meaningful in a file with the executable bit set in its permissions. These files are already correctly non-executable, as they have no “main routine” or interesting side effects and are purely importable modules.
Slightly more detail is available in the commit messages.