Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitize also raises when a neurite has multiple neurite types #52

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Conversation

wizmer
Copy link
Contributor

@wizmer wizmer commented Jan 27, 2021

Sometimes a basal dendrites sprouts an axon. In the current state of things,
this is not supported by the circuit building so let's catch it as early as possible.


Args:
input_folder (str|pathlib.Path): input neuron
output_folder (str|pathlib.Path): output name

.. note:: the sub-directory structure is maintained.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.. note:: is the sphinx directive.

Copy link

@GianlucaFicarelli GianlucaFicarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple of minor comments.

tests/data/neurite-with-multiple-types.swc Outdated Show resolved Hide resolved
tests/test_sanitize.py Outdated Show resolved Hide resolved
Sometimes a basal dendrites sprouts an axon. In the current state of things,
this is not supported by the circuit building so let's catch it as early as possible.
@wizmer wizmer merged commit cd8b87c into BlueBrain:master Jan 27, 2021
@wizmer
Copy link
Contributor Author

wizmer commented Jan 27, 2021

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants