new_axes=False + soma outline fix #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wizmer , what is the best way to fix the python2 issue with latest matplotlib? They made some changes and it prints warnings if we create several axes with same name. It works fine for python3, but latest matplotlib is not python2. Do you guys want to drop python2? |
|
Yes, we want to drop python 2 :) |
|
ok, I let you sort this out then, not sure how to remove py27 checks, just from tox.ini? |
|
It needs to be a separate commit bumping the minor version. |
wizmer
approved these changes
Apr 27, 2020
|
I'm too late but usually when making a change as big as deprecating a python version, it is good that it appears in the commit title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one for not adding new axes (matplotib warns that this may not work as it is in future versions), and use plain soma plot (the contour is a bit buggy with shifted neurons)