lint fixes + improvement of some older code #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the failing CI seems to not be my fault... |
|
Can you add a test ? :) min(last_bif, None)and I don't think this is valid. |
|
This never happens, we always get a float, as said in the docstring. |
mgeplf
reviewed
Oct 16, 2020
lidakanari
reviewed
Oct 20, 2020
adrien-berchet
approved these changes
Oct 22, 2020
arnaudon
changed the title
|
The original aim of this PR is no more, only the lint and old code updates are left. The original PR was implemented elsewhere. @lidakanari , I will let you merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the detected apical point is larger than the last bifurcation, the apical points it not a valid one. Forcing it to be 0.9* distance to last bif makes it a valid one. The choice of 0.9 is arbitrary, and originated because using a factor of 1 did not work later with TNS, possbily due to floating point precision. We can but a smaller fraction than 0.9.