Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create publish-sdist.yml #35

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Create publish-sdist.yml #35

merged 1 commit into from
Dec 8, 2020

Conversation

arnaudon
Copy link
Collaborator

@arnaudon arnaudon commented Dec 8, 2020

No description provided.

@arnaudon arnaudon requested a review from wizmer December 8, 2020 11:03
@arnaudon
Copy link
Collaborator Author

arnaudon commented Dec 8, 2020

Not sure what to do with this one

Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good.
Did you add the secrets.PYPI_PASSWORD in the setting?

@wizmer
Copy link
Contributor

wizmer commented Dec 8, 2020

@adrien-berchet You don't need to, there are some secrets defined at the bluebrain level that you just need to ask core services to activate. And yes, Alexis did it.

@adrien-berchet
Copy link
Member

@adrien-berchet You don't need to, there are some secrets defined at the bluebrain level that you just need to ask core services to activate. And yes, Alexis did it.

Ah ok, good.

@arnaudon
Copy link
Collaborator Author

arnaudon commented Dec 8, 2020

So the CI secret thing works? So I can close the ticket related to that.

@wizmer
Copy link
Contributor

wizmer commented Dec 8, 2020

You need to make a release to see if it pushes to pypi to know that

@arnaudon
Copy link
Collaborator Author

arnaudon commented Dec 8, 2020

Ah yes, ok, we won't do that now, so I'll close the ticket.

@wizmer wizmer merged commit cce24ad into master Dec 8, 2020
@arnaudon arnaudon deleted the ci-migration-2 branch December 8, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants