Use points instead of diameters for MorphIO conversion

[adrien-berchet]

#45 was merged in the wrong branch, this PR just cherry-picks the commit to merge it on the master branch.

[eleftherioszisis]

May I ask why it is preferable to copy a 2D dataset instead of a 1D to get its length?

[adrien-berchet]

May I ask why it is preferable to copy a 2D dataset instead of a 1D to get its length?

Which copy? The points or diameters are not copied, we just use them to know the total number of points.

[arnaudon]

lol: ERROR: Could not build wheels for morphio, which is required to install pyproject.toml-based projects

[eleftherioszisis]

You will need to remove python3.6 as morphio does not create wheels for it after support for python3.6 was dropped.

[eleftherioszisis]

May I ask why it is preferable to copy a 2D dataset instead of a 1D to get its length?

Which copy? The points or diameters are not copied, we just use them to know the total number of points.

Data copied from the c++ to the python side. The only reason I used diameters is that they are 1D so would result in a smaller copy. That said, it doesn't really matter because the datasets are rather small.

[adrien-berchet]

You will need to remove python3.6 as morphio does not create wheels for it after support for python3.6 was dropped.

Ah ok, thanks.

[adrien-berchet]

May I ask why it is preferable to copy a 2D dataset instead of a 1D to get its length?

Which copy? The points or diameters are not copied, we just use them to know the total number of points.

Data copied from the c++ to the python side. The only reason I used diameters is that they are 1D so would result in a smaller copy. That said, it doesn't really matter because the datasets are rather small.

Yeah I think we can use the points for now, and when BlueBrain/MorphIO#357 will be solved we will use it.

[adrien-berchet]

@eleftherioszisis do you have the permissions to discard the py36 required job?

[adrien-berchet]

Hello there,
Do you know if a new release is planned for MorphIO? BlueBrain/MorphIO#357 was merge but we can't use it here without a new release.

[adrien-berchet]

@eleftherioszisis should we merge this one and use n_points method later or should we wait for a new release of MorphIO?

[eleftherioszisis]

May I ask why it is preferable to copy a 2D dataset instead of a 1D to get its length?

Which copy? The points or diameters are not copied, we just use them to know the total number of points.

Data copied from the c++ to the python side. The only reason I used diameters is that they are 1D so would result in a smaller copy. That said, it doesn't really matter because the datasets are rather small.

Yeah I think we can use the points for now, and when BlueBrain/MorphIO#357 will be solved we will use it.

Sorry for responding late. n_points should be available now.