Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests to use pytest & remove warnings #48

Merged
merged 11 commits into from
Mar 6, 2022
Merged

Refactor tests to use pytest & remove warnings #48

merged 11 commits into from
Mar 6, 2022

Conversation

eleftherioszisis
Copy link
Collaborator

@eleftherioszisis eleftherioszisis commented Mar 4, 2022 •
edited

  • Replace nose with pytest
  • Fix warnings
  • Deprecated python3.6
  • Add all supported pythons

adrien-berchet
adrien-berchet reviewed Mar 4, 2022
View reviewed changes
Copy link
Member

@adrien-berchet adrien-berchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!
Just a remark: what about using some fixtures for input data? It would be cleaner because currently if a test update an input data it will be also changed for the following tests.

tox.ini Outdated Show resolved Hide resolved
@eleftherioszisis
Copy link
Collaborator Author

Nice, thanks! Just a remark: what about using some fixtures for input data? It would be cleaner because currently if a test update an input data it will be also changed for the following tests.

That would be too much work. I just wanted to bring it up to shape and remove the annoying warnings, not to rewrite all the tests :P

@adrien-berchet
Copy link
Member

Nice, thanks! Just a remark: what about using some fixtures for input data? It would be cleaner because currently if a test update an input data it will be also changed for the following tests.

That would be too much work. I just wanted to bring it up to shape and remove the annoying warnings, not to rewrite all the tests :P

I understand 😄

@lidakanari lidakanari merged commit 91980c1 into master Mar 6, 2022
@adrien-berchet adrien-berchet deleted the zisis/refactor-tests branch September 6, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-berchet adrien-berchet adrien-berchet approved these changes

@lidakanari lidakanari Awaiting requested review from lidakanari

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eleftherioszisis @adrien-berchet @lidakanari