Feat: Use MorphIO by default and fallback to internal loader in case of failure #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrien-berchet
force-pushed
the
morphio_by_default
branch
from
0b16883
to
9afe611
Compare
adrien-berchet
force-pushed
the
morphio_by_default
branch
2 times, most recently
from
0e2ae90
to
69a5a28
Compare
adrien-berchet
force-pushed
the
morphio_by_default
branch
from
69a5a28
to
758179b
Compare
adrien-berchet
changed the title
adrien-berchet
force-pushed
the
morphio_by_default
branch
from
758179b
to
f41fed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires BlueBrain/MorphIO#431
This is a draft to use MorphIO as default loader. But for now MorphIO silently fixes the loaded morphologies according to arbitrary (though relevant) rules (as described in BlueBrain/MorphIO#427), which is an issue for TMD. So we should update MorphIO to be optionally less strict before making it the default loader.