Add support for side-by-side stereo images (.jps) #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdumusc
force-pushed
the
stereoimage
branch
2 times, most recently
from
42c8565
to
d7a4339
Compare
karjonas
reviewed
Aug 27, 2018
tide/core/data/ImageReader.cpp
Outdated
|
|
||
| QImage _ensureGlCompatibleFormat(const QImage& image) | ||
| { | ||
| const auto argb32 = QImage::Format_ARGB32; |
There was a problem hiding this comment.
hmm that's purely cosmetics so that the next line below fits in one line (<80 characters)...
There was a problem hiding this comment.
Beauty is in the eyes of the beholder :) I think you should remove it and let clang-format handle the layout.
tide/core/data/ImageReader.cpp
Outdated
| return QSize{stereoSize.width() / 2, stereoSize.height()}; | ||
| } | ||
|
|
||
| QRect _getMonoRect(const QSize& image, const deflect::View view) |
karjonas
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.