Add screen power on/off capability to web interface, refactorings #279
Conversation
|
Hold on; looks like some more changes are required to update the screen status icon after the screens have been turned on/off |
rdumusc
force-pushed
the
poweron
branch
3 times, most recently
from
ce43645
to
198729a
Compare
|
OK, should be fine now (tested on 5th floor). |
|
|
||
| bool _getResult(const std::vector<bool>& results) | ||
| { | ||
| for (const auto result : results) |
There was a problem hiding this comment.
| for (const auto result : results) | |
| return std::find(results.begin(), results.end(), false) == results.end(); |
| { | ||
| ScreenState _getResult(const std::vector<ScreenState>& results) | ||
| { | ||
| const auto state = results[0]; |
There was a problem hiding this comment.
Right, this function should be safe even though it normally doesn't happen in this context, updated.
| namespace | ||
| { | ||
| const int serialTimeout = 1000; // in ms | ||
| const int powerStateTimer = 60000; // in ms | ||
| const int readTimeoutMs = 1000; |
There was a problem hiding this comment.
| const int readTimeoutMs = 1000; | |
| constexpr int readTimeoutMs = 1000; |
| #ifndef ScreenController_H | ||
| #define ScreenController_H | ||
| #ifndef SCREEN_CONTROLLER_H | ||
| #define SCREEN_CONTROLLER_H |
There was a problem hiding this comment.
I agree that it's less work and less error prone, I was using pragma once before joining the BBP then I stopped to maintain a consistent style, and now I got used to doing it by hand... ;-) The only times I found hard-coded names to be useful is in the rare cases when you need fine control over which files are included when using conflicting or broken third-party libraries. But that's very uncommon and I agree that it does not apply to this project. Maybe I should consider doing a batch change at some point.
No description provided.