Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multi-finger pan gestures [DISCL-357] #74

Merged
merged 1 commit into from
Aug 8, 2016

Conversation

rdumusc
Copy link

@rdumusc rdumusc commented Aug 8, 2016

No description provided.

@@ -167,7 +170,7 @@ void WebkitPixelStreamer::processMoveEvent(const deflect::Event& moveEvent)
{
const QPoint& pointerPos = getPointerPosition(moveEvent);

if( _interactionModeActive )
if( _interactionModeActive && moveEvent.key < 2 )
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no multi-point pan support yet?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the idea of this check is that multi-finger pan always scrolls the page. This allows to move the page with two fingers even if a webgl canevas is in the way and would otherwise capture the mouse event.

@tribal-tec
Copy link
Contributor

+1

@rdumusc rdumusc merged commit eb3b5bb into BlueBrain:master Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants