Save and restore webbrowsers [DISCL-6] #97
Conversation
|
Bug fixed: https://github.com/BlueBrain/Tide/pull/97/files#diff-c9226f34c0371355af8c7a50e70820b6R82 |
|
|
||
| #include "ThumbnailGenerator.h" | ||
|
|
||
| class WebbrowserThumbnailGenerator : public ThumbnailGenerator |
There was a problem hiding this comment.
doxygen? At least the motivation why webbrowser needs a specialized thumbnail generator.
There was a problem hiding this comment.
Right, will do. I got lazy because none of the existing ThumbnailGenerator classes had been documented so far.
| */ | ||
| enum class StreamType | ||
| { | ||
| STANDARD, |
There was a problem hiding this comment.
That's a good suggestion, thanks.
| @@ -203,7 +193,7 @@ void CommandLineOptions::_parseCommandLineArguments( int& argc, char** argv ) | |||
| } | |||
|
|
|||
| _getHelp = vm.count( "help" ); | |||
| _streamname = vm["streamname"].as<std::string>().c_str(); | |||
| _streamId = vm["streamname"].as<std::string>().c_str(); | |||
There was a problem hiding this comment.
change the commandline option name as well? Or why the 'inconsistency' is introduced?
There was a problem hiding this comment.
Yes, I will adapt further - the idea is to adjust to previous changes in deflect::Stream API which now uses id instead of name.
No description provided.