Simplify database initialization #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan0x
changed the title
tristan0x
force-pushed
the
fix/config
branch
from
1fcedd9
to
6523a62
Compare
ohm314
approved these changes
Feb 18, 2020
tristan0x
pushed a commit
that referenced
this pull request
Feb 18, 2020
Improve error handling and Rocksdb column families setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The new RocksDB boolean configuration key
create_missing_column_familiesdrastically simplifies how the database is configured when created.Removing this chunk of code also gets rid of a bug. An error was silently ignored when RocksDB wasn't linked with snappy but was specified in the database configuration. It led to other errors later...
This PR also makes sure the Basalt graph objects remain in a sane state when an error occurs when opening a RocksDB database.
For reviewers
PLEASE IGNORE FORMATTING CHANGES IN CMake FILES
https://github.com/BlueBrain/basalt/pull/107/files?file-filters%5B%5D=.cpp&file-filters%5B%5D=.hpp&file-filters%5B%5D=.py&file-filters%5B%5D=No+extension