Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use features from luigi >= 3.1 instead of luigi-tools #26

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Use features from luigi >= 3.1 instead of luigi-tools #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions data_validation_framework/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,12 @@
import pandas as pd
from luigi.parameter import ChoiceParameter
from luigi.parameter import DictParameter
from luigi.parameter import OptionalIntParameter
from luigi.parameter import OptionalPathParameter
from luigi.parameter import OptionalStrParameter
from luigi.task import flatten as task_flatten
from luigi_tools.parameter import BoolParameter
from luigi_tools.parameter import OptionalBoolParameter
from luigi_tools.parameter import OptionalIntParameter
from luigi_tools.parameter import OptionalPathParameter
from luigi_tools.parameter import OptionalStrParameter
from luigi_tools.task import CheckUnconsumedParamsMixin
from luigi_tools.task import LogTargetMixin
from luigi_tools.task import RerunMixin
from numpy import VisibleDeprecationWarning
Expand Down Expand Up @@ -122,7 +121,6 @@ def __init__(self, col_mapping, **kwargs):


class BaseValidationTask(
CheckUnconsumedParamsMixin,
LogTargetMixin,
RerunMixin,
TagResultOutputMixin,
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
README = f.read()

reqs = [
"luigi",
"luigi>=3.1",
"luigi-tools>=0.0.18",
"pandas",
"rst2pdf",
Expand Down
2 changes: 1 addition & 1 deletion tests/test_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import pause
import pytest
from diff_pdf_visually import pdfdiff
from luigi_tools.parameter import OptionalStrParameter
from luigi.parameter import OptionalStrParameter

from data_validation_framework import report
from data_validation_framework import result
Expand Down