Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug with trifurcations #18

Merged
merged 1 commit into from Mar 16, 2022
Merged

bug with trifurcations #18

merged 1 commit into from Mar 16, 2022

Conversation

arnaudon
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #18 (563777e) into main (8be3723) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   85.21%   85.23%   +0.02%     
==========================================
  Files          11       11              
  Lines        1109     1111       +2     
  Branches      236      236              
==========================================
+ Hits          945      947       +2     
  Misses        119      119              
  Partials       45       45              
Flag Coverage Δ
pytest 85.23% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
diameter_synthesis/build_diameters.py 89.95% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8be3723...563777e. Read the comment docs.

@adrien-berchet
Copy link
Member

adrien-berchet commented Mar 16, 2022

Are trifurcations allowed in valid morphs? I thought only bifurcations were valid.

@arnaudon arnaudon merged commit 5673885 into main Mar 16, 2022
@adrien-berchet adrien-berchet deleted the bug_tri branch March 16, 2022 10:38
@arnaudon
Copy link
Contributor Author

some reconstructions have them, but our code support it, but in the wrong way, so better to have it supported properly

@adrien-berchet
Copy link
Member

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants