Started python-only features, added initburst_sahp as first example #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
- Coverage 100% 99.33% -0.67%
==========================================
Files 5 7 +2
Lines 228 299 +71
==========================================
+ Hits 228 297 +69
- Misses 0 2 +2
Continue to review full report at Codecov.
|
mgeplf
reviewed
Jun 5, 2018
| @@ -33,6 +33,8 @@ | |||
| import efel | |||
| import efel.cppcore as cppcore | |||
|
|
|||
| import efel.pyfeatures as pyfeatures | |||
There was a problem hiding this comment.
from efel import cppcore, pyfeatures ?
There was a problem hiding this comment.
Yeah, Werner implemented some new features just in Python. One issue I found in using Python-only features is that getDistance function knows only about c++ features names.
(https://github.com/BlueBrain/eFEL/blob/master/efel/api.py#L196)
I can try to think about a work-around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.