Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Neo integration for NWB support #383

Merged
merged 14 commits into from
Apr 29, 2024
Merged

Update Neo integration for NWB support #383

merged 14 commits into from
Apr 29, 2024

Conversation

ilkilic
Copy link
Collaborator

@ilkilic ilkilic commented Apr 26, 2024

This PR updates NEO integration to support NWB formats and introduces a new example that demonstrate how to load data with NEO.

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@ilkilic ilkilic changed the title Update Neo integration Update Neo integration for NWB support Apr 29, 2024
@ilkilic ilkilic marked this pull request as ready for review April 29, 2024 10:07
@ilkilic ilkilic requested a review from anilbey April 29, 2024 10:07
@ilkilic ilkilic self-assigned this Apr 29, 2024
Copy link
Collaborator

@anilbey anilbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great.

Could you address the following also:

  • the name of the example can be more explicit perhaps nwb-via-neo or load-nwb or something similar
  • If possible, in the notebook besides the interspike interval, could you show at least one other feature? The sonata-network notebook is also showing the interspike interval feature. Some different feature/features would be good to show on the experimental data. E.g. perhaps some burst related feature as Rajnish mentioned. cc @darshanmandge which features may be suited for this experimental NWB
  • Could you modify the docs/examples_to_rst.sh script @AurelienJaquier had created to make sure this notebook will be rendered in the docs?

@darshanmandge
Copy link

Thanks @ilkilic ! You can use this burst related features: spikes_per_burst, strict_burst_number, strict_burst_mean_freq

@ilkilic
Copy link
Collaborator Author

ilkilic commented Apr 29, 2024

I have made the requested changes in the latest commits

@anilbey
Copy link
Collaborator

anilbey commented Apr 29, 2024

Wow looks so good, thanks a lot @ilkilic

@ilkilic ilkilic merged commit 42a8b44 into master Apr 29, 2024
20 checks passed
@ilkilic ilkilic deleted the neo branch April 29, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants