Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch multiple exceptions for np.polyfit #385

Merged
merged 3 commits into from
Apr 30, 2024
Merged

catch multiple exceptions for np.polyfit #385

merged 3 commits into from
Apr 30, 2024

Conversation

anilbey
Copy link
Collaborator

@anilbey anilbey commented Apr 30, 2024

Description

Catches both errors (np.linalg.LinAlgError, SystemError) in np.polyfit call.

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@anilbey anilbey marked this pull request as ready for review April 30, 2024 14:44
Copy link

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future reader: this was needed for ISI_log_slope.
Works now. Thanks.

@anilbey anilbey merged commit c019492 into master Apr 30, 2024
20 checks passed
@anilbey anilbey deleted the exceptions branch April 30, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants