Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set settings logger with debug instead of warning #392

Merged
merged 2 commits into from
May 7, 2024

Conversation

AurelienJaquier
Copy link
Collaborator

Description

Motivation: Overall I don't this this should be a warning, a simple debug statement is enough. There are a lot of stuff that are not defined in settings, but can be set as such (stim_start, stim_end, stimulus_current, etc.), this is something expected.

BluePyEModel sets stimulus_current, sometimes even stim_start, stim_end, and I see this warning a lot

Checklist:

  • Unit tests are added to cover the changes (skip if not applicable).
  • The changes are mentioned in the documentation (skip if not applicable).
  • CHANGELOG file is updated (skip if not applicable).

@AurelienJaquier AurelienJaquier self-assigned this May 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.80%. Comparing base (2cddd26) to head (2b368fd).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   91.73%   91.80%   +0.07%     
==========================================
  Files          36       37       +1     
  Lines        6278     6956     +678     
  Branches     2033     2245     +212     
==========================================
+ Hits         5759     6386     +627     
- Misses        266      298      +32     
- Partials      253      272      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ilkilic ilkilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree

@AurelienJaquier AurelienJaquier merged commit 226ea09 into BlueBrain:master May 7, 2024
20 checks passed
@AurelienJaquier AurelienJaquier deleted the stop-flood branch May 7, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants