New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: mention RemoveCorruptedOutput with an example #11
Conversation
I think we could also improve the tests of this feature a little bit. For example we could use |
Co-authored-by: Adrien Berchet <adrien.berchet@epfl.ch>
Hmm, something fishy is happening with the tests. The tests work as excepted but the Luigi exception is no longer caught. |
assert with the complete() method of task instance
Ok, the exception gets handled by Luigi. I removed the try blocks and added extra assert statements that check the |
Ah yes ok. If you want to see an example on how to check the exception raised inside a task you can look here: https://github.com/BlueBrain/luigi-tools/blob/main/tests/test_task.py#L420 But it's not the main point of this feature so it's as you prefer. |
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
Add more details for the RemoveCorruptedOutput class in README
Updated README to provide an example for the RemoveCorruptedOutputMixin.