Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open Sourcing Checklist fixes #6

Merged
merged 15 commits into from
Apr 13, 2022
Merged

Open Sourcing Checklist fixes #6

merged 15 commits into from
Apr 13, 2022

Conversation

FrancescoCasalegno
Copy link
Contributor

@FrancescoCasalegno FrancescoCasalegno commented Apr 12, 2022 •
edited
Loading

This PR should implement all fixes required by our QA ("OS Quality Requirements") before making the code public.

In particular, the following changes were made:

  • 1.C - Authors in setup.py
  • 1.D - CONTRIBUTIONS.txt
  • 2.A - Top-Level Information
  • 2.B - Section "Install"
  • 2.C - Section "Examples"
  • 3.A - Copyright, Funding & Authors
  • 3.B - License
  • 3.C - License Notice

@FrancescoCasalegno FrancescoCasalegno self-assigned this Apr 12, 2022
Stannislav
Stannislav reviewed Apr 12, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Stannislav
Stannislav approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@Stannislav Stannislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@FrancescoCasalegno FrancescoCasalegno merged commit 72f59fa into main Apr 13, 2022
@FrancescoCasalegno FrancescoCasalegno deleted the opensourcing-checklist branch April 13, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stannislav Stannislav Stannislav approved these changes

Assignees

@FrancescoCasalegno FrancescoCasalegno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FrancescoCasalegno @Stannislav