Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CUDA Docker image bug + Improve Dockerfile + Add requirements-extra.txt #62

Merged
merged 7 commits into from
May 17, 2022

Conversation

FrancescoCasalegno
Copy link
Contributor

@FrancescoCasalegno FrancescoCasalegno commented May 17, 2022

Fixes NVIDIA/nvidia-docker#63

Description

  1. Fix the public key is not available: NO_PUBKEY bug by using the workaround suggested in GPG error "public key is not available" in Ubuntu 20.04 CUDA 11.4.0 image while building NVIDIA/nvidia-container-toolkit#257
  2. Remove PIP_INDEX_URL pointing at BBP internal Python index from the Dockerfile (otherwise pip install neurots will look for the wrong package in our index instead of PyPI!)
  3. Introduce requirements-extra.txt to cover the requirements of extras_require.

How to test?

  1. Running docker build should now succeed.
  2. Running pip install .[dev,test] inside the container should install morphoclass and confirm that all dependencies are already there.

Checklist

  • This PR refers to an issue from the issue tracker.
    (if it is not the case, please create an issue first).
  • setup.cfg, requirements.txt, and constraints.txt updated with new dependencies.
    (if needed)
  • All CI tests pass.

@FrancescoCasalegno FrancescoCasalegno self-assigned this May 17, 2022
@FrancescoCasalegno FrancescoCasalegno changed the title Fix CUDA Docker image bug + improve Dockerfile Fix CUDA Docker image bug + Improve Dockerfile + Add requirements-extra.txt May 17, 2022
@FrancescoCasalegno FrancescoCasalegno marked this pull request as ready for review May 17, 2022 11:49
@FrancescoCasalegno FrancescoCasalegno merged commit 41b318f into main May 17, 2022
@FrancescoCasalegno FrancescoCasalegno deleted the docker-env branch May 17, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nvidia-docker should be more obvious about no-op pass-through
1 participant