Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change to use _self value as id when retrieving a resource. #271

Merged
merged 20 commits into from May 22, 2023

Conversation

crisely09
Copy link
Contributor

This is a veeeery simple approach that achieves the desired behavior in #270

Unit tests are missing at the moment.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #271 (6dcfeea) into master (1f23719) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   72.87%   72.67%   -0.20%     
==========================================
  Files          88       88              
  Lines        5607     5622      +15     
==========================================
  Hits         4086     4086              
- Misses       1521     1536      +15     
Flag Coverage Δ
unittests 72.67% <0.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kgentitylinkingsklearn/entity_linking_sklearn.py 0.00% <0.00%> (ø)
kgforge/specializations/stores/bluebrain_nexus.py 21.73% <0.00%> (-0.70%) ⬇️

@crisely09 crisely09 merged commit d5de1ef into BlueBrain:master May 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants