New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use full url to download files. #283
Conversation
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
- Coverage 72.85% 72.75% -0.10%
==========================================
Files 88 88
Lines 5574 5583 +9
==========================================
+ Hits 4061 4062 +1
- Misses 1513 1521 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Looks good. Fixed the following errors (introduced in previous merged commits) occurring when downloading:
|
I see that you added the solution to the cross_bucket problem here, that is good, two birds in one shot. Maybe we could add an example for downloading using |
It is mentioned both in the Querying and Dataset notebooks. |
Related to #282
The idea is to check if the contentUrl is already expanded and use it as given.
When the file_id is passed, then do the standard url construction, i.e. endpoint/org/proj/file_id .