Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration option to resolve within a given ontology #290

Merged
merged 10 commits into from Apr 14, 2023

Conversation

crisely09
Copy link
Contributor

@crisely09 crisely09 commented Feb 10, 2023

The option to search within an ontology was added inside the configuration file, and the parameter to trigger this is resolving_context which should match one of the contexts names provided in the configuration.
Done:

  • Unit tests
  • Examples in resolving notebooks.

@crisely09 crisely09 requested a review from MFSY February 10, 2023 15:47
@crisely09
Copy link
Contributor Author

@MFSY this is ready to be reviewed

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #290 (7fd2d51) into master (3a9d774) will increase coverage by 0.17%.
The diff coverage is 65.17%.

@@            Coverage Diff             @@
##           master     #290      +/-   ##
==========================================
+ Coverage   72.68%   72.85%   +0.17%     
==========================================
  Files          86       88       +2     
  Lines        5499     5574      +75     
==========================================
+ Hits         3997     4061      +64     
- Misses       1502     1513      +11     
Impacted Files Coverage Δ
kgentitylinkingsklearn/entity_linking_sklearn.py 0.00% <0.00%> (ø)
..._linking/service/entity_linking_elastic_service.py 37.73% <0.00%> (-0.73%) ⬇️
kgforge/specializations/resolvers/store_service.py 21.42% <13.63%> (-9.61%) ⬇️
...gforge/specializations/resolvers/agent_resolver.py 58.97% <35.71%> (+16.11%) ⬆️
...rge/specializations/resolvers/ontology_resolver.py 59.45% <42.85%> (+14.36%) ⬆️
kgforge/specializations/stores/bluebrain_nexus.py 22.34% <50.00%> (-5.03%) ⬇️
kgforge/specializations/resolvers/demo_resolver.py 47.76% <57.14%> (-1.45%) ⬇️
.../resolvers/entity_linking/entity_linker_elastic.py 62.06% <62.50%> (-5.94%) ⬇️
kgforge/core/archetypes/resolver.py 64.39% <74.46%> (+2.85%) ⬆️
kgforge/core/commons/sparql_query_builder.py 92.98% <92.98%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@crisely09 crisely09 changed the title Added configuration option to revolve within a given ontology Added configuration option to resolve within a given ontology Feb 24, 2023
@MFSY
Copy link
Collaborator

MFSY commented Apr 7, 2023

@MFSY this is ready to be reviewed

I proposed to use the existing resolving 'target' as a way to specify the ontology to resolve to.

@crisely09
Copy link
Contributor Author

@MFSY Done, now it uses a dictionary. I also changed filter to filters because we are assuming that we can have more than one.

@crisely09 crisely09 merged commit 051eb73 into master Apr 14, 2023
1 check passed
@crisely09 crisely09 deleted the ontology_resolver branch April 14, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants