Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support removing tags from resources #1001

Merged
merged 2 commits into from Dec 9, 2021
Merged

Conversation

nicwells
Copy link
Contributor

@nicwells nicwells commented Dec 3, 2021

Fixes BlueBrain/nexus#2934

Description

A dropdown button has been added to the resource advanced view tab. In the dropdown it lists the tags that exist on the resource along with the associated revision. Clicking on one of the tabs will display a confirmation message requiring the user to confirm their intention to remove the tag. The button is displayed only on the latest revision of the resource.

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@nicwells nicwells marked this pull request as ready for review December 8, 2021 14:55
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M3@2049eff). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M3    #1001   +/-   ##
===========================================
  Coverage            ?   66.00%           
===========================================
  Files               ?       21           
  Lines               ?      609           
  Branches            ?      126           
===========================================
  Hits                ?      402           
  Misses              ?      207           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2049eff...a17aebf. Read the comment docs.

@dhaneshnm dhaneshnm merged commit b0adcb7 into 1.7.0-M3 Dec 9, 2021
@dhaneshnm dhaneshnm deleted the 2934-delete-tag-on-resource branch December 9, 2021 09:18
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
Co-authored-by: Dhanesh Neela Mana <dhanesh.neelamana@epfl.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants