Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle objects in search #1007

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Handle objects in search #1007

merged 2 commits into from
Dec 14, 2021

Conversation

dhaneshnm
Copy link
Contributor

@dhaneshnm dhaneshnm commented Dec 14, 2021

The value can be an object. So, we need to serialize it before rendering.
Fixes #

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M3@bbee557). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e6deec1 differs from pull request most recent head 68b7be2. Consider uploading reports for the commit 68b7be2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M3    #1007   +/-   ##
===========================================
  Coverage            ?   66.00%           
===========================================
  Files               ?       21           
  Lines               ?      609           
  Branches            ?      126           
===========================================
  Hits                ?      402           
  Misses              ?      207           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbee557...68b7be2. Read the comment docs.

@dhaneshnm dhaneshnm merged commit a333d57 into 1.7.0-M3 Dec 14, 2021
@dhaneshnm dhaneshnm deleted the handle-objects-in-search branch December 14, 2021 12:48
dhaneshnm pushed a commit that referenced this pull request Dec 14, 2021
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants