Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array values #1010

Merged
merged 2 commits into from Dec 23, 2021
Merged

Fix array values #1010

merged 2 commits into from Dec 23, 2021

Conversation

dhaneshnm
Copy link
Contributor

@dhaneshnm dhaneshnm commented Dec 17, 2021

When array values are null, or actually not array but object type, do type check and caste it in to array.

Description

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (1.7.0-M3@8bcea07). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             1.7.0-M3    #1010   +/-   ##
===========================================
  Coverage            ?   65.95%           
===========================================
  Files               ?       21           
  Lines               ?      611           
  Branches            ?      126           
===========================================
  Hits                ?      403           
  Misses              ?      208           
  Partials            ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcea07...b5a5b76. Read the comment docs.

@nicwells nicwells merged commit 8c262fc into 1.7.0-M3 Dec 23, 2021
@nicwells nicwells deleted the fix-array-values branch December 23, 2021 15:39
dhaneshnm pushed a commit that referenced this pull request Mar 11, 2022
* Fix array values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants